Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Commit

Permalink
Merge pull request #645 from lmorchard/640-uninstall-survey
Browse files Browse the repository at this point in the history
Do not block or cancel experiment uninstall with survey dialog
  • Loading branch information
Cory Price committed Apr 26, 2016
2 parents 39541dc + 11de2f6 commit e181c39
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions testpilot/frontend/static-src/app/views/experiment-page.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,13 @@ export default PageView.extend({

const queryParams = querystring.stringify({ref: 'disable', experiment: this.model.title});

this.uninstall(evt);

this.renderSubview(new DisableDialogView({
id: 'disabled-feedback',
experiment: this.model.url,
title: 'feedbackUninstallTitle',
surveyUrl: `${this.model.survey_url}?${queryParams}`,
onSubmit: () => this.uninstall(evt)
surveyUrl: `${this.model.survey_url}?${queryParams}`
}), 'body');
},

Expand Down

0 comments on commit e181c39

Please sign in to comment.