Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Navigation API (positive) #830

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Add Navigation API (positive) #830

merged 2 commits into from
Jun 21, 2023

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 20, 2023

Fixes #543

@zcorpan zcorpan requested a review from smaug---- June 20, 2023 12:12
martinthomson
martinthomson approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing mdnUrl. I don't know why the validator didn't notice. Other than that, this looks OK

activities.json Outdated Show resolved Hide resolved
@zcorpan zcorpan merged commit 79df09a into main Jun 21, 2023
@zcorpan zcorpan deleted the zcorpan/navigation-api branch June 21, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@smaug---- smaug---- Awaiting requested review from smaug----

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation API
2 participants
@zcorpan @martinthomson