Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename import attributes to import conditions #392

Merged
merged 2 commits into from
Jul 13, 2020
Merged

rename import attributes to import conditions #392

merged 2 commits into from
Jul 13, 2020

Conversation

xtuc
Copy link
Contributor

@xtuc xtuc commented Jul 13, 2020 •
edited
Loading

The proposal was renamed to import-conditions, I don't know if it's supposed to be edited here.

dbaron
dbaron approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, with one nit (see below). Thanks for submitting the PR.

activities.json Outdated Show resolved Hide resolved
@dbaron dbaron merged commit 25cea3c into mozilla:master Jul 13, 2020
@xtuc xtuc deleted the sven/rename-import-conditions branch July 13, 2020 20:56
@xtuc xtuc mentioned this pull request Jul 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaron dbaron dbaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtuc @dbaron