This repository has been archived by the owner on May 22, 2021. It is now read-only.
refactored css: phase 1 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdehaan
reviewed
Feb 15, 2018
app/base.css
Outdated
| cursor: pointer; | ||
|
|
||
| /* Force flat button look */ | ||
| appearance: none; |
There was a problem hiding this comment.
FWIW, this is the warning output from Stylelint:
app/base.css
106:3 ⚠ Unexpected browser feature plugin/no-unsupported-browser-features
"css-appearance" is only
partially supported by
Firefox 52,56,57, Chrome
61,62, Safari 10,11,9.1,10.1
dannycoates
force-pushed
the
refactor-css
branch
7 times, most recently
from
5809355
to
f4ca3ae
Compare
dannycoates
force-pushed
the
refactor-css
branch
from
f4ca3ae
to
8d41111
Compare
dannycoates
force-pushed
the
refactor-css
branch
3 times, most recently
from
1f58d91
to
bdc41b7
Compare
flodolo
reviewed
Feb 17, 2018
public/locales/en-US/send.ftl
Outdated
| @@ -113,3 +113,4 @@ enableJavascript = Please enable JavaScript and try again. | |||
| expiresHoursMinutes = { $hours }h { $minutes }m | |||
| # A short representation of a countdown timer containing the number of minutes remaining as digits, example "56m" | |||
| expiresMinutes = { $minutes }m | |||
| passwordIsSet = Password set | |||
There was a problem hiding this comment.
Can you add some context in a comment about where this string shows up?
dannycoates
force-pushed
the
refactor-css
branch
from
bdc41b7
to
346e604
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly extracts the css into separate files and tries to make the naming scheme follow BEM.
There's still the opportunity to dedupe more (like a
.pageblock) and extract colors for example. At least this passesstylelintagain.