Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Adding basic ESLint config #54

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Conversation

pdehaan
Copy link
Collaborator

@pdehaan pdehaan commented Jun 7, 2017

This only adds ESLint, not CSS/style linting.

Ref: #27

@ericawright
Copy link
Contributor

Looks good. But prettier is already in, we don't need both, right? I haven't figured out how to customize prettier yet, so I prefer this ;)

@pdehaan
Copy link
Collaborator Author

pdehaan commented Jun 7, 2017

Well... I think prettier is more for code formatting, whereas eslint is better suited for code validation and enforcing rules. Definitely some areas of overlap (indentation, quotes, etc) though.

We could use prettier as a plugin for eslint using something like eslint-plugin-prettier, but I find that flow a bit awkward and difficult to maintain.

@pdehaan
Copy link
Collaborator Author

pdehaan commented Jun 8, 2017

Current ESLint stats with this PR merged:

✖ 103 problems (86 errors, 17 warnings)

Lint stats after running $ npm run lint -- --fix and auto-fixing code:

✖ 48 problems (31 errors, 17 warnings)

I can try fixing most of the issues in a follow-up PR/commit, but didn't want to cause a big diff churn here to make it easier to review.

@dannycoates
Copy link
Contributor

Thanks @pdehaan!

@abhinadduri @dnarcese let's get this merged after #71 then create an issue to fix the lint errors

@pdehaan
Copy link
Collaborator Author

pdehaan commented Jun 9, 2017

@dannycoates Rebased. 👀

@dannycoates dannycoates merged commit 3c9889c into mozilla:master Jun 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants