This repository has been archived by the owner on May 22, 2021. It is now read-only.
Chain jQuery calls, do not use events alias and store selectors #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdehaan
reviewed
Aug 4, 2017
frontend/src/upload.js
Outdated
| $copyBtn.html( | ||
| '<img src="/resources/check-16.svg" class="icon-check"></img>' | ||
| ); | ||
| window.setTimeout(() => { | ||
| $copyBtn.attr('disabled', false); | ||
| $('#link').attr('disabled', false); | ||
| $link.attr('disabled', false); |
There was a problem hiding this comment.
You could potentially move $link.attr() up a line and chain both $copyBtn.attr() calls.
I think you can also set multiple values in a single .attr() by passing an object: http://api.jquery.com/attr/#attr-attributes
$link.attr('disabled', false);
$copyBtn.attr({
disabled: false,
'data-l10n-id': 'copyUrlFormButton'
});There was a problem hiding this comment.
changed that thank you @pdehaan 👍
|
Thanks @Johann-S 👍 |
This was referenced Dec 14, 2020
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some improvements about perfs and good practices.
.clicktransformed to.on('click')$(document).readyto$(function () { })with jQuery 3 it's recommended to use this form to listen the DOM ready events (see : https://api.jquery.com/ready/)Fix : #284