This repository has been archived by the owner on May 22, 2021. It is now read-only.
Extended system font list fixes:#408 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gautamkrishnar thank you for taking this! The only issue here is that it removes 'SF Pro Text' from the list, and that is the font that the mocks were based off of. I'm not certain yet if we want to accept this suggestion. |
|
This PR can display UTF8 character as well as it should. With SF Pro Display, some text will become this. (The word "Gửi") |
|
Thank you @gautamkrishnar 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended system font list fixes:#408. Please inform me if you need to make any changes.