Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Only include Fira CSS on /unsupported/* route #415

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

pdehaan
Copy link
Collaborator

@pdehaan pdehaan commented Aug 3, 2017

Fixes #391

@ericawright
Copy link
Contributor

Looks good. I also wonder if using Fira was intentional, since this is the only place it's used. But that's a question for @Pekochen, and in the meantime I see no problem with merging this.

@dannycoates dannycoates merged commit 95e3ca7 into mozilla:master Aug 3, 2017
@pdehaan
Copy link
Collaborator Author

pdehaan commented Aug 3, 2017

Looks good. I also wonder if using Fira was intentional, since this is the only place it's used. But that's a question for @Pekochen, and in the meantime I see no problem with merging this.

I'd be more than happy to remove Fira. It feels a bit aggressive to display it only on that page. "Sorry your browser is unsupported, but here is an additional 170.75KB of fonts"...

firefox_send

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants