This repository has been archived by the owner on May 22, 2021. It is now read-only.
Show error page if upload fails #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericawright
approved these changes
Jul 6, 2017
pdehaan
reviewed
Jul 6, 2017
frontend/src/fileSender.js
Outdated
| @@ -51,6 +51,9 @@ class FileSender extends EventEmitter { | |||
| reader.onload = function(event) { | |||
| resolve(new Uint8Array(this.result)); | |||
| }; | |||
| reader.onerror = function(event) { | |||
| reject(event.explicitOriginalTarget.error.name); | |||
There was a problem hiding this comment.
@dnarcese @abhinadduri Are these errors logged and sent through Raven?
There was a problem hiding this comment.
Nope, should be fairly easy to send them to Raven though.
pdehaan
reviewed
Jul 6, 2017
frontend/src/upload.js
Outdated
| notify('Your upload has finished.'); | ||
| }) | ||
| .catch(err => { | ||
| console.log('Upload error name: ' + err); |
There was a problem hiding this comment.
Same as above, are these errors logged and sent through Raven at all?
There was a problem hiding this comment.
This one is a bit more tricky: if the user accidentally tampers with the salt, this error would trigger. Is that something we would want to send to Raven?
There was a problem hiding this comment.
I think that only sending the error to Raven here is sufficient? This will eliminate any duplicates, since errors from the reader.onerror triggers (#168 (diff)) are always caught here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file cannot be uploaded, show a very simple error page (which will be changed with new designs).