Fixed ToC and added back Storage Options section #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added sections not shown in the ToC. - Fixed ToC to reproduce the same order as the actual sections. - The README still referenced the no longer existing section "Storage Options". I added back that option with the same links as in the ToC.
drahnr
reviewed
Mar 10, 2023
drahnr
approved these changes
Mar 10, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
- Coverage 29.66% 29.57% -0.09%
==========================================
Files 49 49
Lines 17012 17012
Branches 8188 8188
==========================================
- Hits 5047 5032 -15
- Misses 6991 6994 +3
- Partials 4974 4986 +12 see 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Storage Options" section had been removed, but not all the references to it (first paragraph), the same holds for the subsection named "Local", which -- however -- has a separate document as replacement now. Since there was no replacement that could be linked, I reintroduced the section "Storage Options" and reproduced the links to the external files there. Only remaining question from my end, do the references to the external documents really have to be in the ToC?