-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new feature vendored-openssl
#1648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it is very red in the CI :) |
Seems to be caused by the |
The integration tests mostly passed and one is still running, so I don't think the CI failure is caused by this PR. |
I'm guessing you need to update the |
Aha you are right! |
@Xuanwo I've updated the |
Could you please add some docs about this? |
To build and use a vendored version of `openssl` for cases where the environment does not have openssl installed, e.g. in cross compilation.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 29.56% 29.54% -0.02%
==========================================
Files 49 49
Lines 17012 17012
Branches 8188 8200 +12
==========================================
- Hits 5029 5027 -2
+ Misses 6995 6993 -2
- Partials 4988 4992 +4 see 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@sylvestre I've added comment explaining what |
The FreeBSD failure seems to be caused by pizzamig failed to umount/cleanup. |
yeah, i was hoping for the README.md (mostly) ;) |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@sylvestre Thanks, I've updated README.md |
To build and use a vendored version of
openssl
for cases where the environment does not have openssl installed, e.g. in cross compilation.