-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable connection pool to fix dist server feature #1612
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov ReportBase: 30.80% // Head: 30.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1612 +/- ##
==========================================
- Coverage 30.80% 30.77% -0.04%
==========================================
Files 49 49
Lines 16661 16667 +6
Branches 8061 8063 +2
==========================================
- Hits 5133 5129 -4
+ Misses 6242 6237 -5
- Partials 5286 5301 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
I have repeated the test of dist server several times, it is now stable! |
excellent, thanks. let's see if it sticks. |
what is the impact for the users ? |
No difference. We already send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, other than that, looks good to me
Signed-off-by: Xuanwo <github@xuanwo.io>
A job is failing to build. Maybe related to the fs err change? |
Fixed now. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
Thanks for the squash :) |
The root cause of dist server restart failure seems related to request's http keep-alive logic.
More details could be found here: #1563
In the future, we should use the same global client instead and bring connection pool back.