Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically remove "awaiting response" label on-comment #1129

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

mitchhentges
Copy link
Contributor

Also will close tickets that have been "awaiting response" for over 15 days.

@mitchhentges
Copy link
Contributor Author

I have about 80% confidence that this is set up correctly:

  • Is ${{ github.token }} automatically filled in? Sounds like it, but unsure
  • Will this behave properly since the awaiting response label already exists?
  • v0.5.0 👀
  • I can't test auto-ticket closures in a fork

However, perusing through the active tickets in the no-response repo doesn't show anything too concerning, and the main benefit is that awaiting response labels will be auto-cleared on-response, which will make it easier to ensure that issues/PRs don't fall through the cracks, while we also don't waste time checking incomplete PRs/issues.

TL;DR: the failure case if this doesn't work is likely that this change will essentially be a no-op. I'm feeling lucky, though I trust your judgement Sylvestre.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #1129 (cd5a02f) into main (18ead2f) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   34.65%   34.72%   +0.06%     
==========================================
  Files          47       47              
  Lines       12638    12638              
  Branches     6589     6589              
==========================================
+ Hits         4380     4388       +8     
+ Misses       4012     4011       -1     
+ Partials     4246     4239       -7     
Impacted Files Coverage Δ
src/test/utils.rs 36.36% <0.00%> (-2.03%) ⬇️
src/mock_command.rs 51.66% <0.00%> (-1.11%) ⬇️
src/compiler/rust.rs 31.85% <0.00%> (+0.06%) ⬆️
src/compiler/c.rs 38.31% <0.00%> (+0.93%) ⬆️
src/util.rs 42.48% <0.00%> (+1.12%) ⬆️
src/azure/blobstore.rs 23.15% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ead2f...cd5a02f. Read the comment docs.

@mitchhentges
Copy link
Contributor Author

This codecov report is reducing my trust in the tool, because I have no Rust code here.
I wonder if it's comparing my branch to mozilla/sccache:main rather than rebasing and comparing my commits that are part of this PR.

@jschwe
Copy link
Contributor

jschwe commented Feb 18, 2022

This codecov report is reducing my trust in the tool, because I have no Rust code here.

I don't know too much about codecov, but we probably anyway want to switch to -Zinstrument-coverage, since that is on track to be stabilized in 1.60, while the -Zprofile option probably will never be stabilized. instrument-coverage should AFAIK be more accurate.

@mitchhentges mitchhentges force-pushed the awaiting-response-action branch from 5866830 to 50bc026 Compare March 10, 2022 16:17
@mitchhentges mitchhentges force-pushed the awaiting-response-action branch from 50bc026 to 8e878a1 Compare March 10, 2022 16:18
Also will close tickets that have been "awaiting response" for over 15 days.
@mitchhentges mitchhentges force-pushed the awaiting-response-action branch from 8e878a1 to cd5a02f Compare March 11, 2022 18:38
@mitchhentges mitchhentges merged commit 443b124 into mozilla:main Mar 15, 2022
@mitchhentges mitchhentges deleted the awaiting-response-action branch March 15, 2022 16:08
mitchhentges added a commit that referenced this pull request Mar 15, 2022
mitchhentges added a commit that referenced this pull request Mar 15, 2022
emabrey pushed a commit to emabrey/sccache that referenced this pull request Aug 10, 2022
Also will close tickets that have been "awaiting response" for over 15 days.
emabrey pushed a commit to emabrey/sccache that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants