Fix RegExp.prototype[Symbol.match] and String.prototype.match #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajirrao
force-pushed
the
fix-regex-match
branch
from
83fd8b4 to
556070c
Compare
gbrail
reviewed
Feb 19, 2025
| @@ -66,7 +66,7 @@ protected boolean isDone(Context cx, Scriptable scope) { | |||
| return true; | |||
| } | |||
|
|
|||
| next = regExpExec(cx, scope); | |||
| next = NativeRegExp.regExpExec(regexp, string, cx, scope); | |||
There was a problem hiding this comment.
Could you please pop down to line 98 and get rid of the private method "regExpExec" that's no longer used?
|
This is great -- thanks! I looked at the test coverage and it looks good, and I see how many things it fixes. I'd appreciate it if you could remove that unused method (there's a warning from Errorprone about it in the build output). Thanks! |
|
@gbrail thanks for taking a look! Will fix, rebase and push once CI is back to green on master. |
The spec requires that Symbol.match call the exec method in a loop.
As per the spec, it is simply supposed to invoke the Symbol.match of the regexp.
balajirrao
force-pushed
the
fix-regex-match
branch
from
556070c to
eba34cf
Compare
|
This looks very good -- thanks! p.s. I'm about to finish reorganizing NativeString completely into lambda functions so this comes just in time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two fixes based on the spec:
RegExp.prototype[Symbol.match]: The spec requires that this method invoke theexecmethod of the regular expression in a loop.String.prototype.match: The spec mandates that this method callRegExp.prototype[Symbol.match].As a result, a few new test262 tests now pass. The remaining failing tests in
built-ins/RegExp/prototype/Symbol.matchandbuilt-ins/String/prototype/matchare unrelated to this fix.