Allow updating of name of a function, as required by the standard
#1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbri
reviewed
Oct 20, 2023
|
|
||
| @Test | ||
| public void canSetFunctionNameInInterpreter() { | ||
| try (Context cx = Context.enter()) { |
There was a problem hiding this comment.
please use Utils.runWithAllOptimizationLevels like many of the other tests are doing
There was a problem hiding this comment.
And please fix formating, see https://github.com/mozilla/rhino#code-formatting
There was a problem hiding this comment.
Done and done.
Totally missed the code formatting, my bad. :-)
|
maybe it is better to have the tests in the testsrc/org/mozilla/javascript/tests/es6 folder |
|
Did you also run the Test262 Suite to see if any tests got unbroken there? See https://github.com/mozilla/rhino/blob/master/testsrc/README.md |
|
I've fixed some 262 tests that were broken, and I have also updated the list of failing tests. Seven more 262 tests now pass! |
|
This makes sense to me -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1297
This PR fixes only Function.name, not the whole issue. 🙂