Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M21 rebase #952

Closed
wants to merge 129 commits into from
Closed

M21 rebase #952

wants to merge 129 commits into from

Conversation

jezdez
Copy link

@jezdez jezdez commented May 13, 2019 •
edited
Loading

Applied commits

Dropped commmits

Dropped commits WITH TODOs

Collapsed commits (of the applied above)

  1. Schema Drawer
  1. Circle CI setup
  • 9372e73a9: Update Circle CI for our workflow
  • e9d733972: Fix yaml and add tag filters for other tests (Fix yaml and add tag filters for other tests #923)
  • a76333615: Don't use extra hyphens in our custom version.
  • 1b088ec4a: Appease SemVer by using - instead of +.

arikfr and others added 30 commits March 18, 2019 11:13
@arikfr
Fix: make sure that only the top level node_modules directory is excl…
9de676a 
…uded (getredash#3600)

* Fix: make sure that only the top level node_modules directory is excluded

* Remove old unused packing script
@arikfr
Remove node_modules before creating tarball (getredash#3603)
15c815f 
* Update pack

* Remove node_modules before packing
Nest query ACL to dropdowns (getredash#3544)
c47dd05 
* change API to /api/queries/:id/dropdowns/:dropdown_id

* extract  property

* split to 2 different dropdown endpoints and implement the second

* make access control optional for dropdowns (assuming it is verified at a
different level)

* add test cases for /api/queries/:id/dropdowns/:id

* use new /dropdowns endpoint in frontend

* require access to dropdown queries when creating or updating parent
queries

* rename Query resource dropdown endpoints

* check access to dropdown query associations in one fugly query

* move ParameterizedQuery to models folder

* add dropdown association tests to query creation

* move group by query ids query into models.Query

* use bound parameters for groups query

* format groups query

* use new associatedDropdowns endpoint in dashboards

* pass down parameter and let it return dropdown options. Go Levko!

* change API to /api/queries/:id/dropdowns/:dropdown_id

* split to 2 different dropdown endpoints and implement the second

* use new /dropdowns endpoint in frontend

* pass down parameter and let it return dropdown options. Go Levko!

* fix bad rebase

* add comment to clarify the purpose of checking the queryId
@kravets-levko
[Bug fix] Query Results fails to use query which has double quotes in…
4e69b73 
… column names (getredash#3618)
@ranbena
Widget tests - add, remove, auto height (getredash#3590)
a7b930a
@ranbena
Added a skipped test for issue getredash#3202 (getredash#3616)
2f8aade
@ranbena
Fix for time based mongodb test (getredash#3630)
aea3c9d
@arikfr
E2E test for query search (getredash#3633)
e712c19 
* Apply prettier to app-header.html.
* Add: E2E test for query search
@arikfr
Fix: triggers not created for queries.search_vector (getredash#3631)
173f9ba
@jezdez @arikfr
Fix a DeprecationWarning about the Flask.static_path parameter. (getr…
8e5ba80 
…edash#3624)

Code: https://github.com/pallets/flask/blob/d1d82ca8ce7262ad9d27245ce44f86571287810e/flask/app.py#L347-L351
@gabrieldutra
Move cypress to client folder (getredash#3566)
25910e7
@gabrieldutra
Replace toastr with Ant Notification (getredash#3610)
b4a4ee2
@justinclift @arikfr
Update docker compose with the stable Redash v7 tag (getredash#3638)
1d7378f
@gabrieldutra
Add env var to skip Flask rate limits (getredash#3622)
70d4c72
@ranbena
Widget drag tests (getredash#3598)
0995dfb
@ranbena
Cypress eslint fixes and config (getredash#3636)
ec4b36b
@arikfr @ranbena
Add Lint step to CircleCI (getredash#3642)
fd42091
@ranbena
Migrated Textbox edit dialog to React (getredash#3632)
8230098
@kravets-levko
[Feature] Migrate Admin pages to React (getredash#3568)
73c8e30
@jezdez @arikfr
Fix a few more inconsistencies when loading and dumping JSON. (getred…
77c5313 
…ash#3626)

* Fix a few more inconsistencies when loading and dumping JSON.

Refs getredash#2807. Original work in: getredash#2817

These change have been added since c2429e9.

* Review fixes.
@jezdez @arikfr
Use flask-talisman for handling backend response headers (getredash#3404
712fc63 
)

* Normalize Flask initialization API use.

* Use Flask-Talisman.

* Enable HSTS when HTTPS is enforced.

* More details about how CSP is formatted and write CSP directives as a string.

* Use CSP frame-ancestors directive and not X-Frame-Options for embedable endpoints.

* Add link to flask-talisman docs.

* set remember_token cookie to be HTTP-Only and Secure

* Reorganize secret key configuration to be forward thinking and backward compatible.
@jezdez @arikfr
Render LDAP and remote auth login links correctly when multi org mode…
6c26aa7 
… is enabled. (getredash#3530)

* Make LDAP auth handler org scoped.

* Render LDAP and remote auth login links correctly when multi org mode is enabled.
@ranbena @arikfr
Browser support config (getredash#3609)
b5d97e2 
* Browser support config

* Removed some offending code

* Added unsupported html page and redirect for IE

* Typo in regex

* Made html page static

* Added redirect script to multi_org

* Moved static html page to client/app
@combineads @arikfr
Add phoenix query runner. (getredash#3153)
71afc99 
* Add phoenix query runner.

* Improved error handling.
@arikfr
Fail query task properly even if error message is empty (getredash#3499)
d5494cf
@arikfr
Fix email shows as unverified when no email server is configured (get…
49ffaae 
…redash#3613)

* check that e-mail server is configured before marking the email address
as not verified and sending out a verification e-mail

* use helper method in `invite_user`

* move email_server_configured helper to settings

* add test to verify that email addresses arent marked as unverified if
there's no e-mail server to verify them

* simplify a couple of tests with patch

* combine conditions into single variable

* Booleans, gotta love 'em
@ialeinikov @arikfr
allowing to specify a custom work group for AWS Athena queries (getre…
7a7fdf9 
…dash#3592)

* allowing to specify a custom work group for AWS Athena queries

* Fixing title + adding correct position in the UI
@justinclift @arikfr
Update PostgreSQL version to always use latest in the 9.5 series (get…
973ad56 
…redash#3639)
@arikfr
Show accessible tables only in New Query view for PostgreSQL (getreda…
872d0ca 
…sh#3599)

* Show accessible tables only.

* Get table information from information_schema.columns.

* Union old query.
@gabrieldutra @arikfr
Add error message when destination name already exists (getredash#3597)
375e61f 
* Return 400 when destination name already exists

* Remove whitespace

* Unicode 1

Co-Authored-By: gabrieldutra <nesk.frz@gmail.com>

* Unicode 2

Co-Authored-By: gabrieldutra <nesk.frz@gmail.com>
Marina Samuel and others added 9 commits May 15, 2019 14:34
@emtwo
Copy link

emtwo commented May 15, 2019

There are 6 commits up at https://github.com/mozilla/redash/tree/emtwo/m21 :

  • The first 3 are a rebase of 567d6ce and 086533b
  • The 4th is a bug fix I found in the pg query. I think it may have been a rebase error?
  • The 5th one is to bring toggling back.
  • The 6th one took a bit of exploration. Essentially, it looks like when I checked out the release branch and tested it locally, version and doc url were available. However they don't seem available in r-c which makes me suspect maybe there is an issue with deploying the extensions?

However, the only minor issue is that when a new data source is created, it doesn't automatically populate the version toggle or doc url, they remain empty. So by default these features would not be on. I am just proposing a way in that commit to make them default on.

Marina Samuel and others added 6 commits May 16, 2019 16:36
@alison985 @jezdez
Schema Viewer Drawer (getredash#3291)
3f00108 
* Process extra column metadata for a few sql-based data sources.

* Add Table and Column metadata tables.

* Periodically update table and column schema tables in a celery task.

* Fetching schema returns data from table and column metadata tables.

* Add tests for backend changes.

* Front-end shows extra table metadata and uses new schema response.

* Delete datasource schema data when deleting a data source.

* Process and store data source schema when a data source is first created or after a migration.

* Tables should have a unique name per datasource.

* Addressing review comments.

* Update migration file for mixins.

* Appease PEP8

* Upgrade migration file for rebase.

* Cascade delete.

* Adding org_id

* Remove redundant column and table prefixes.

* Non-existing tables and columns should be filtered out on the server side not client side.

* Fetching table samples should be optional and should happen in a separate task per table.

* Allow users to force a schema refresh.

* Use updated_at to help prune old schema metadata periodically.

* Using settings.SCHEMAS_REFRESH_QUEUE

* fix for getredash#2426 test

* more stable test_interactive_new

* Closes #927, #928: Schema refresh improvements.

* Closes #934, #935: Remove type from schema browser and don't show empty example column in schema drawer (#936)

* Speed up schema fetch requests with fewer postgres queries.

* Add column metadata to Athena glue processing.

* Fix bug assuming 'metadata' exists for every table.

* Closes #939: Persisted, existing table metadata should be updated.

* Sample processing should be rate-limited.

* Add cli command for refreshing data samples.

* Schema refreshes should not overwrite column 'example' field.

* refresh_samples() should filter tables_to_sample on the datasource's id being sampled

* Correctly wrap long text in schema drawer.

Co-authored-by: Alison <github@bankofknowledge.net>
@jezdez
bump redash-stmo
092fa68
@jezdez
Fix migration names.
6b19137
@jezdez
Schema Improvements Part 2: Add data source config options.
fd4f684
@jezdez
Schema Improvements Part 2: Rebase Commit.
bc4add2
@jezdez
Adding BigQuery schema drawer with data types and samples.
b90b5e2
@jezdez
Copy link
Author

jezdez commented May 16, 2019

There are 6 commits up at /m21@emtwo :

* The first 3 are a rebase of  [567d6ce](https://github.com/mozilla/redash/commit/567d6ce944b2a628ccd6c1e01fb2f1fd6414f133) and [086533b](https://github.com/mozilla/redash/commit/086533b109678ed999a9f16f5a95dde883bd9554)

* The 4th is a bug fix I found in the pg query. I think it may have been a rebase error?

* The 5th one is to bring toggling back.

I've merged those commits into the individual feature commits.

* The 6th one took a bit of exploration. Essentially, it looks like when I checked out the `release` branch and tested it locally, version and doc url were available. However they don't seem available in r-c which makes me suspect maybe there is an issue with deploying the extensions?

Hm, that'd be odd, I'll double check this..

However, the only minor issue is that when a new data source is created, it doesn't automatically populate the version toggle or doc url, they remain empty. So by default these features would not be on. I am just proposing a way in that commit to make them default on.

Ok, let's go with the patch and see if this makes sense. Can you follow-up with this upstream after the deploy?

@emtwo
Copy link

emtwo commented May 16, 2019

  • The 6th one took a bit of exploration. Essentially, it looks like when I checked out the release branch and tested it locally, version and doc url were available. However they don't seem available in r-c which makes me suspect maybe there is an issue with deploying the extensions?

Hm, that'd be odd, I'll double check this..

Yes thank you I wanted to also ask if you could do that.

However, the only minor issue is that when a new data source is created, it doesn't automatically populate the version toggle or doc url, they remain empty. So by default these features would not be on. I am just proposing a way in that commit to make them default on.

Ok, let's go with the patch and see if this makes sense. Can you follow-up with this upstream after the deploy?

Well this patch is a proposal so it would need more changes to work for all data source. I've only done it for postgres as an example. It would also need a change in the redash-stmo repo for doc_url to work.

I can file an issue upstream though I think this might be intended behaviour. Given the fact that this is a small issue with intended behaviour and requires changes to redash-stmo, I'm wondering if we can postpone addressing this to the next release? I think more importantly would be to address the above issue to see why it works on the release branch but not r-c

@jezdez
Copy link
Author

jezdez commented May 16, 2019

  • The 6th one took a bit of exploration. Essentially, it looks like when I checked out the release branch and tested it locally, version and doc url were available. However they don't seem available in r-c which makes me suspect maybe there is an issue with deploying the extensions?

Hm, that'd be odd, I'll double check this..

Yes thank you I wanted to also ask if you could do that.

However, the only minor issue is that when a new data source is created, it doesn't automatically populate the version toggle or doc url, they remain empty. So by default these features would not be on. I am just proposing a way in that commit to make them default on.

Ok, let's go with the patch and see if this makes sense. Can you follow-up with this upstream after the deploy?

Well this patch is a proposal so it would need more changes to work for all data source. I've only done it for postgres as an example. It would also need a change in the redash-stmo repo for doc_url to work.

I can file an issue upstream though I think this might be intended behaviour. Given the fact that this is a small issue with intended behaviour and requires changes to redash-stmo, I'm wondering if we can postpone addressing this to the next release? I think more importantly would be to address the above issue to see why it works on the release branch but not r-c

Makes sense to me, I'll remove

  • The 6th one took a bit of exploration. Essentially, it looks like when I checked out the release branch and tested it locally, version and doc url were available. However they don't seem available in r-c which makes me suspect maybe there is an issue with deploying the extensions?

Hm, that'd be odd, I'll double check this..

Yes thank you I wanted to also ask if you could do that.

Sure no problem.

However, the only minor issue is that when a new data source is created, it doesn't automatically populate the version toggle or doc url, they remain empty. So by default these features would not be on. I am just proposing a way in that commit to make them default on.

Ok, let's go with the patch and see if this makes sense. Can you follow-up with this upstream after the deploy?

Well this patch is a proposal so it would need more changes to work for all data source. I've only done it for postgres as an example. It would also need a change in the redash-stmo repo for doc_url to work.

I can file an issue upstream though I think this might be intended behaviour. Given the fact that this is a small issue with intended behaviour and requires changes to redash-stmo, I'm wondering if we can postpone addressing this to the next release? I think more importantly would be to address the above issue to see why it works on the release branch but not r-c

Okay, that works for me, so I'm removing e999042b1c5a1075bb8143dcebc3e84f292316f6 again?

@emtwo
Copy link

emtwo commented May 16, 2019

Okay, that works for me, so I'm removing e999042 again?

Yes please. Sorry for the confusion

@jezdez
Copy link
Author

jezdez commented May 16, 2019

Okay, that works for me, so I'm removing e999042 again?

Yes please. Sorry for the confusion

All good, just wanted to be clear. 👍

@jezdez
Copy link
Author

jezdez commented May 16, 2019

This has been pushed to release.

@jezdez
Copy link
Author

jezdez commented Jun 11, 2019

Closing since this has been merged and released.

@jezdez jezdez closed this Jun 11, 2019
@jezdez jezdez deleted the m21-rebase branch August 2, 2019 09:21
@snyk-bot snyk-bot mentioned this pull request Aug 17, 2021
Open
@MaxMood96 MaxMood96 mentioned this pull request May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jezdez jezdez

@emtwo emtwo

@jasonthomas jasonthomas

@washort washort

Labels
None yet
Projects
None yet
Milestone
No milestone