Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to docker-entrypoint for worker and scheduler #364

Merged
merged 4 commits into from
Apr 11, 2018

Conversation

jasonthomas
Copy link
Member

I've added --max-memory-per-child to 1/4 of the available system memory. I think this will assist with workers being reaped by OOMKiller and other memory issues we have seen.

--maxtasksperchild was renamed to --max-tasks-per-child in Celery 4 [1].

/cc @robotblake

r?

[1] https://github.com/celery/celery/blob/8047ca9e818db8151dc6c80814600797ab94f5bc/docs/history/whatsnew-4.0.rst#worker

@jezdez
Copy link

jezdez commented Apr 11, 2018

We should send a PR for this upstream as well.

@jezdez
Copy link

jezdez commented Apr 11, 2018

@jasonthomas r+

@washort washort merged commit 7118fe3 into mozilla:master Apr 11, 2018
emtwo pushed a commit that referenced this pull request May 25, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
washort pushed a commit that referenced this pull request Jul 25, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
washort pushed a commit that referenced this pull request Jul 30, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Aug 16, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Sep 6, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Sep 6, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Sep 6, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Nov 1, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Dec 12, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Dec 17, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Dec 19, 2018
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez pushed a commit that referenced this pull request Jan 25, 2019
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
@jezdez
Copy link

jezdez commented Mar 22, 2019

Opened getredash#3625 to track this upstream.

jezdez pushed a commit that referenced this pull request Mar 25, 2019
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
washort pushed a commit that referenced this pull request Mar 26, 2019
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants