Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 add db column type schema browser #173

Merged

Conversation

alison985
Copy link

@alison985 alison985 requested a review from washort July 28, 2017 16:30
@alison985 alison985 added this to the 8 milestone Jul 28, 2017
@washort
Copy link

washort commented Jul 28, 2017

r+

@alison985 alison985 merged commit 4f20015 into mozilla:master Aug 2, 2017
@vcarciu
Copy link

vcarciu commented Aug 8, 2017

Please add some STRs to this issue

@alison985
Copy link
Author

@vcarciu

  1. Login to re:dash and go to the query page.
  2. Select a the metadata data source from the drop-down menu.
  3. The schema browser should come up (or is already) on the left of the screen.
  4. Click on a table to open the list of fields.

passing:
You see the field type in () at the end of the line.

failing:
You only see the field name without the type.

@vcarciu
Copy link

vcarciu commented Aug 9, 2017

I am still seeing only the field name without the type on Stage : https://www.screencast.com/t/TIVm7Q24I5C

@alison985
Copy link
Author

Interesting @vcarciu - I see them on staging: https://www.dropbox.com/s/ul308cw41kpbljr/Screenshot%202017-08-09%2011.51.51.png?dl=0

What URL were you at for the screencast?

@vcarciu
Copy link

vcarciu commented Aug 10, 2017

Hello @alison985 ,

It looks that it is working now for me too for "Redash Metadata" data source, but not for other source . Please see a screencast for "Athena" data source(you can see the url in screencast) : https://www.screencast.com/t/btrad3uDX7Q

@alison985
Copy link
Author

@vcarciu I don't know why this isn't working for Athena, but it is working for postgres and not causing any other issues so I'm not going to delay M8 release. I will open a bug for looking into the Athena issue.

@vcarciu
Copy link

vcarciu commented Aug 10, 2017

@alison985 : please note that this is working only for "Redash metadata" , so if you open a separate issue, please open for all the other data sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants