Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version control for queries #7

Closed
rafrombrc opened this issue Oct 12, 2016 · 6 comments
Closed

Support version control for queries #7

rafrombrc opened this issue Oct 12, 2016 · 6 comments
Assignees
Milestone

Comments

@rafrombrc
Copy link
Member

rafrombrc commented Oct 12, 2016

Users would like to be able to keep track of edits made to their queries, with the ability to see prior versions, to see diffs between versions, and to revert to earlier versions. Requiring an explicit action to save a version is acceptable. It seems reasonable to still use the database as the production source of the currently active query, rather than trying to load the query directly from whatever versioning mechanism is used.

@fbertsch
Copy link

fbertsch commented Nov 4, 2016

Another interesting point brought up in bug 1315081 is, if we have a repo, one can put in a PR for a query.

@washort
Copy link

washort commented Nov 14, 2016

Backend support for this is in redash master now. All edits to queries and dashboards are saved to a changes table.

@rafrombrc rafrombrc added this to the 1 milestone Jan 20, 2017
@spasovski spasovski self-assigned this Jan 20, 2017
@spasovski
Copy link

spasovski commented Jan 20, 2017

  • solve current version number being wrong (too high)
  • CSS z-index cleanup (ideally by moving to Stylus)
  • figure out proper place to wait for XHR API response

@rafrombrc
Copy link
Member Author

Relevant: getredash#1550.

@rafrombrc rafrombrc modified the milestones: 2, 1 Feb 17, 2017
@rafrombrc rafrombrc modified the milestones: 3, 2 Mar 10, 2017
@rafrombrc
Copy link
Member Author

Reopening bc there are JS errors preventing this from working correctly in production.

@rafrombrc rafrombrc modified the milestones: 5, 3 Apr 13, 2017
@rafrombrc rafrombrc reopened this Apr 13, 2017
@rafrombrc rafrombrc modified the milestones: 6, 5 Jun 21, 2017
@alison985 alison985 modified the milestones: 7, 6, 8 Jul 25, 2017
washort pushed a commit that referenced this issue Mar 26, 2019
washort pushed a commit that referenced this issue Jun 10, 2019
washort pushed a commit that referenced this issue Jun 27, 2019
washort pushed a commit that referenced this issue Jun 28, 2019
emtwo pushed a commit that referenced this issue Jul 15, 2019
emtwo pushed a commit that referenced this issue Jul 17, 2019
washort pushed a commit that referenced this issue Sep 16, 2019
emtwo pushed a commit that referenced this issue Nov 5, 2019
wlach pushed a commit to wlach/redash that referenced this issue Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants