Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issue in bars charts #425

Open
madalincm opened this issue Jun 19, 2018 · 4 comments
Open

Display issue in bars charts #425

madalincm opened this issue Jun 19, 2018 · 4 comments

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Open https://pipeline-sql.stage.mozaws.net/queries/374#460
  2. Hover over the gray bar and observe the graphic.

Expected results:

All the information are displayed completely and correctly aligned to the bars

Actual results:

  • the value displayed on the x axis are not aligned with the bars
  • "the app 2.0.1 - Android 22" string is not correctly aligned with the bar

Notes/Issues:

Verified in FF60(Win7). Issue can be reproduced in STMO-stage
This is probably a regression from #395

Screencast for this issue:

truncatedstring

@madalincm madalincm added the bug label Jun 19, 2018
jezdez added a commit that referenced this issue Jun 21, 2018
This reverts commit 25b73e4.

Refs #437 and #425.
@jezdez
Copy link

jezdez commented Jun 21, 2018

This seems to be a general issue, even after we reverted #395. Leaving this open for further triage.

@rafrombrc rafrombrc added this to the 17 milestone Jul 16, 2018
@rafrombrc rafrombrc modified the milestones: 17, 18, 19, 20 Nov 7, 2018
@spasovski spasovski self-assigned this Mar 8, 2019
@spasovski
Copy link

As far as I can tell this should be fixed after we bump plotly to the latest release. This fork is on plotly.js 1.41.3 and current (as of this comment) is 1.45.3. The release notes can be found here: https://github.com/plotly/plotly.js/releases

@jezdez
Copy link

jezdez commented Mar 27, 2019

IMO the risk for side-effects is to high for such an important part of Redash. Let's open a PR to do this upstream instead. We can create a query in the preview instance upstream to reproduce this as part of the PR.

@jezdez jezdez modified the milestones: 20, 21 May 9, 2019
@jezdez
Copy link

jezdez commented Aug 7, 2019

Upstream plotly is still 1.41.3, I'll open a ticket upstream asking if we can upgrade it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants