-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "Toggle Versioned Tables" doesn't actually do that #356
Comments
I don't believe this was a change in behavior, but perhaps a change in data! Turns out that Angular's filtering feature looks at all strings in objects, no matter how deeply nested, so filtering out "_v" was filtering out tables that had columns like "app_version". I've fixed it to only filter on table name. |
I can still reproduce this issue in FF59(Win7) in STMO-stage
-- "normandy_stage.auto_json_log_normandy_admin_csp", " stmo.churn" and other tables that are not ending with "_v[x]" are removed |
Verified in FF59(Win7) |
When selecting "Toggle Versioned Tables", I would expect it to add/remove versioned tables - those that end with
_vN
. While most of them are removed, most of the unversioned tables are removed as well, e.g.addon_aggregates
.The text was updated successfully, but these errors were encountered: