Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Toggle Versioned Tables" doesn't actually do that #356

Closed
fbertsch opened this issue Apr 3, 2018 · 3 comments
Closed

The "Toggle Versioned Tables" doesn't actually do that #356

fbertsch opened this issue Apr 3, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@fbertsch
Copy link

fbertsch commented Apr 3, 2018

When selecting "Toggle Versioned Tables", I would expect it to add/remove versioned tables - those that end with _vN. While most of them are removed, most of the unversioned tables are removed as well, e.g. addon_aggregates.

@washort
Copy link

washort commented Apr 4, 2018

I don't believe this was a change in behavior, but perhaps a change in data! Turns out that Angular's filtering feature looks at all strings in objects, no matter how deeply nested, so filtering out "_v" was filtering out tables that had columns like "app_version". I've fixed it to only filter on table name.

@washort washort closed this as completed Apr 4, 2018
@washort washort added this to the 13.1 milestone Apr 4, 2018
@madalincm
Copy link

I can still reproduce this issue in FF59(Win7) in STMO-stage

  1. Go to https://pipeline-sql.stage.mozaws.net/queries/new
  2. Select Athena as data source and use the toggle versioned switch

-- "normandy_stage.auto_json_log_normandy_admin_csp", " stmo.churn" and other tables that are not ending with "_v[x]" are removed

@madalincm madalincm reopened this Apr 11, 2018
@madalincm
Copy link

Verified in FF59(Win7)
At this moment there aren't any versioned tables so using the switch has no effect.
Giving this we can assume that the switch is no longer removing unversioned tables but I can't verify that versioned tables are removed correctly. I will be able to verify that only after the fix hits production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants