Skip to content

Commit

Permalink
Fix query id in parameter querystring names (fixes #942) (#969)
Browse files Browse the repository at this point in the history
This was broken by upstream changes.
  • Loading branch information
Allen Short committed Jun 27, 2019
1 parent 4d800d8 commit 25adf75
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions client/app/services/query.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export class Parameter {
this.useCurrentDateTime = parameter.useCurrentDateTime;
this.global = parameter.global; // backward compatibility in Widget service
this.enumOptions = parameter.enumOptions;
this.queryId = parameter.queryId;
this.parentQueryId = parentQueryId;

// Used for meta-parameters (i.e. dashboard-level params)
Expand Down Expand Up @@ -175,7 +174,7 @@ export class Parameter {
};
}
return {
[`${prefix}${this.name}_${this.queryId}`]: this.value,
[`${prefix}${this.name}_${this.parentQueryId}`]: this.value,
};
}

Expand All @@ -188,7 +187,7 @@ export class Parameter {
this.setValue([query[keyStart], query[keyEnd]]);
}
} else {
const key = `${prefix}${this.name}_${this.queryId}`;
const key = `${prefix}${this.name}_${this.parentQueryId}`;
if (has(query, key)) {
this.setValue(query[key]);
}
Expand Down

0 comments on commit 25adf75

Please sign in to comment.