Unique names for query parameters (re #164)

mozilla · Jan 16, 2020 · 1dc6c4a · 1dc6c4a
1 parent d2943b9
commit 1dc6c4a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/client/app/services/parameters/Parameter.js b/client/app/services/parameters/Parameter.js
@@ -131,14 +131,14 @@ class Parameter {
     const prefix = this.urlPrefix;
     // `null` removes the parameter from the URL in case it exists
     return {
-      [`${prefix}${this.name}`]: !this.isEmpty ? this.value : null,
+      [`${prefix}${this.name}_${this.parentQueryId}`]: !this.isEmpty ? this.value : null,
     };
   }
 
   /** Set parameter value from the URL */
   fromUrlParams(query) {
     const prefix = this.urlPrefix;
-    const key = `${prefix}${this.name}`;
+    const key = `${prefix}${this.name}_${this.parentQueryId}`;
     if (has(query, key)) {
       this.setValue(query[key]);
     }

diff --git a/client/app/services/query.js b/client/app/services/query.js
@@ -380,7 +380,7 @@ function QueryResource($resource, $http, $location, $q, currentUser, QueryResult
       });
     }
     Object.keys(params).forEach(key => params[key] == null && delete params[key]);
-    params = map(params, (value, name) => `${encodeURIComponent(name)}=${encodeURIComponent(value)}`).join("&");
+    params = map(params, (value, name) => `${encodeURIComponent(name)}_${this.id}=${encodeURIComponent(value)}`).join("&");
 
     if (params !== "") {
       url += `?${params}`;