Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote groups #29

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Remote groups #29

merged 2 commits into from
Mar 26, 2019

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Mar 22, 2019 •
edited
Loading

Port REMOTE_GROUPS feature from upstream (the fork).

See mozilla/redash#311 and mozilla/redash#37.

@jezdez jezdez requested review from emtwo and jasonthomas March 22, 2019 11:38
@jezdez jezdez mentioned this pull request Mar 25, 2019
Merged
6 tasks
emtwo
emtwo approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@emtwo emtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I might take it for a test drive later today but no need to block merging

@jezdez
Copy link
Contributor Author

jezdez commented Mar 26, 2019

@emtwo Thanks for the review!

@jezdez jezdez merged commit 13a0a43 into master Mar 26, 2019
@jezdez jezdez deleted the remote-groups branch March 26, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emtwo emtwo emtwo approved these changes

@jasonthomas jasonthomas Awaiting requested review from jasonthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jezdez @emtwo