Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incorrect/useless argument line #19473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthiassent
Copy link

I found this line that calls parent function in widgetAnnotation with five arguments instead of four. "false" is passed instead of annotationStorage. Is this expected/normal ?

annotationStorage does not seem to be used in the function anyway but I thought I might report.

@calixteman
Copy link
Contributor

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ffa0c41acbc09b1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b65e62a9a5a0442/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ffa0c41acbc09b1/output.txt

Total script time: 29.31 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the commit message to properly explain what you're changing, why the change is correct, and also include a reference to the PR/commit that introduced the code.

Please keep in mind that it should be possible to understand what a patch does and why on e.g. the git command line as well; please take a look at the commit history for this project to see how we usually write commit messages.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b65e62a9a5a0442/output.txt

Total script time: 59.71 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants