Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the "Blank issue" alternative when using the GitHub "New issue"-button #19419

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 4, 2025

With recent changed made to the GitHub issues-UI the "Blank issue" alternative is now showing up quite prominently, which can easily negate the point of our bug/feature templates and lead to incomplete issues being filed.

…e"-button

With recent changed made to the GitHub issues-UI the "Blank issue" alternative is now showing up quite prominently, which can easily negate the point of our bug/feature templates and lead to incomplete issues being filed.
@Snuffleupagus Snuffleupagus force-pushed the blank_issues_enabled-false branch from 1fae03f to 0b118ef Compare February 4, 2025 14:19
@nicolo-ribaudo
Copy link
Contributor

Note that if somebody really wants to open a blank issue (e.g. for something like #19412, which is more of a reminder than a bug report), they'll still be able to do it at https://github.com/mozilla/pdf.js/issues/new. The option just disables button in the list, and not the functionality.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 5, 2025

The option just disables button in the list, and not the functionality.

That's fine, since I just wanted to get rid of the now prominent entry (highlighted in red):

chooser

@timvandermeij timvandermeij merged commit 5b7bc27 into mozilla:master Feb 7, 2025
7 checks passed
@timvandermeij
Copy link
Contributor

Good idea!

@Snuffleupagus Snuffleupagus deleted the blank_issues_enabled-false branch February 7, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants