Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp the hival parameter of Indexed color space to the range [0; 255] #18890

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

calixteman
Copy link
Contributor

Since this value is used to allocate an array, it makes sense to avoid to use too much memory.
From the specs, this value must be in the range [0; 255] (see section 8.6.6.3).
This patch removes the unused property 'highVal'.

@calixteman
Copy link
Contributor Author

The idea comes from here: https://issues.chromium.org/issues/372749732
/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8a6a2849e38aa69/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/83ced48cd2873bb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/8a6a2849e38aa69/output.txt

Total script time: 30.90 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 14
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/8a6a2849e38aa69/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/83ced48cd2873bb/output.txt

Total script time: 46.36 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/83ced48cd2873bb/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus changed the title Clamp the hival parameter of Indexed color space to then range [0; 255] Clamp the hival parameter of Indexed color space to the range [0; 255] Oct 12, 2024
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling nit: Change then -> the in the commit message.

r=me, thank you.

Since this value is used to allocate an array, it makes sense to avoid to use too much memory.
From the specs, this value must be in the range [0; 255] (see section 8.6.6.3).
This patch removes the unused property 'highVal'.
@calixteman calixteman merged commit 1c0c070 into mozilla:master Oct 12, 2024
8 checks passed
@calixteman calixteman deleted the clamp_indexedcs_hival branch October 12, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants