Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty fields are 0 when using AFSimple_Calculate #18552

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Empty fields are 0 when using AFSimple_Calculate #18552

merged 1 commit into from
Aug 3, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #18536 and #18532.

@calixteman calixteman linked an issue Aug 2, 2024 that may be closed by this pull request
[Bug]: Form Field Calculation Triggering Unexpectedly or not getting trigger at all. #18532
Closed
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bd6c758efd672d1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/06aa3821640aa51/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/06aa3821640aa51/output.txt

Total script time: 8.50 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bd6c758efd672d1/output.txt

Total script time: 18.07 mins

  • Integration Tests: Passed

@Snuffleupagus
Copy link
Collaborator

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/21727c9d5624f66/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bc0f7455b9ecd05/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/21727c9d5624f66/output.txt

Total script time: 2.46 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bc0f7455b9ecd05/output.txt

Total script time: 7.59 mins

  • Unit Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman calixteman merged commit c60c0d1 into mozilla:master Aug 3, 2024
8 checks passed
@calixteman calixteman deleted the issue18536 branch August 3, 2024 13:10
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-js
Projects
None yet
Milestone
No milestone
3 participants
@calixteman @moz-tools-bot @Snuffleupagus