Inline single-line event handlers in the web/app.js file
#18527
Conversation
Snuffleupagus
force-pushed
the
app-inline-short-listeners
branch
2 times, most recently
from
83b143a
to
879d0bb
Compare
We have a fair number of (effectively) single-line event handlers in the `web/app.js` file, which leads to unnecessarily verbose code. These can, without affecting readability too much, be replaced either by: - Using `bind` for the simplest cases. - Using arrow-functions for the remaining ones. Note that this is possible since we started removing event listeners with `AbortSignal`, which means that we no longer need to keep a reference to the event handler functions to be able to remove them. Given that the old event handler functions use fairly long function names, and the way that they access `PDFViewerApplication` (given their scope), they impact the overall code-size unnecessarily. *Note:* This patch reduces the size of the `gulp mozcentral` output by `~3.7` kilo-bytes, which isn't a lot but still cannot hurt.
Snuffleupagus
force-pushed
the
app-inline-short-listeners
branch
from
879d0bb
to
89f3a26
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/377aa1b13f4ff09/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c0ee1d01c7b2f70/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/377aa1b13f4ff09/output.txt Total script time: 8.46 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c0ee1d01c7b2f70/output.txt Total script time: 17.45 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e4a5c1f0315c219/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e4a5c1f0315c219/output.txt Total script time: 1.04 mins Published |
|
Looks much better and easier to manage like this; nice work! |
We have a fair number of (effectively) single-line event handlers in the
web/app.jsfile, which leads to unnecessarily verbose code. These can, without affecting readability too much, be replaced either by:bindfor the simplest cases.Note that this is possible since we started removing event listeners with
AbortSignal, which means that we no longer need to keep a reference to the event handler functions to be able to remove them.Given that the old event handler functions use fairly long function names, and the way that they access
PDFViewerApplication(given their scope), they impact the overall code-size unnecessarily.Note: This patch reduces the size of the
gulp mozcentraloutput by~3.7kilo-bytes, which isn't a lot but still cannot hurt.