Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give all HTML button elements a type #18517

Merged
merged 1 commit into from
Aug 1, 2024

Commits on Jul 30, 2024

  1. Give all HTML button elements a type

    The HTML button elements we use are all regular buttons that don't
    submit form data to a server. According to
    https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#notes
    those buttons should all have their type set to `button` explicitly, but
    we only do that a handful of them. This commit fixes the issue by
    consistently giving all our buttons the `button` type.
    
    Co-authored-by: Calixte Denizet <calixte.denizet@gmail.com>
    timvandermeij and calixteman committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f1f58bb View commit details
    Browse the repository at this point in the history