Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to the most recent versions #18473

Closed
wants to merge 1 commit into from

Conversation

timvandermeij
Copy link
Contributor

Note that there are no translation updates upstream this time. This is likely the final update before the next release.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/694a426049b12bc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/694a426049b12bc/output.txt

Total script time: 1.19 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/edcb325c096ae1d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/9324bc9eae55e48/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/edcb325c096ae1d/output.txt

Total script time: 32.04 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 15
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/edcb325c096ae1d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/9324bc9eae55e48/output.txt

Total script time: 46.86 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/9324bc9eae55e48/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Jul 21, 2024

The Error: Cannot dismiss dialog which is already handled! integration test issue is a new one and most likely caused by the Puppeteer update. I'll look into what's causing that: it could be an issue upstream in Puppeteer, or indicate something that's not good in our test code that just surfaced because of the update. It's interesting that for these three tests the dialog.dismiss() call seems to fail, but that same call does work for other tests we have...

The closest upstream PR I could find related to this is puppeteer/puppeteer#12744 which touched this file recently (but in a seemingly trivial way).

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Jul 21, 2024

I reproduced the issue locally and confirmed only Firefox is impacted by it: the validation dialog stays open while it should have closed. However, I noticed puppeteer/puppeteer#12744 (comment) and figured my Firefox 130 Nightly version might not have that fix yet, so I purged my local cache and indeed the newly downloaded Firefox 130 Nightly version works. We should remove the cached Firefox 130 Nightly versions from both the Windows and Linux bots so we can retry this.

@calixteman Could you perform this action on both bots? The paths to the Firefox binaries are printed at the top of the bot logs above. Thanks!

@calixteman
Copy link
Contributor

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/93e7a69aae3f35b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/28bbafde9141f63/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/93e7a69aae3f35b/output.txt

Total script time: 15.32 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.241.84.105:8877/93e7a69aae3f35b/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/28bbafde9141f63/output.txt

Total script time: 48.38 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/28bbafde9141f63/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dec6810b8cb3389/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3372d921fce1c12/output.txt

@timvandermeij timvandermeij marked this pull request as draft July 26, 2024 16:40
@timvandermeij
Copy link
Contributor Author

I have converted this to draft because I'll update it later today with the latest updates from the last few days.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3372d921fce1c12/output.txt

Total script time: 36.39 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 1860
  different ref/snapshot: 9
  different first/second rendering: 4

Image differences available at: http://54.241.84.105:8877/3372d921fce1c12/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/dec6810b8cb3389/output.txt

Total script time: 45.89 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/dec6810b8cb3389/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij deleted the updates branch July 26, 2024 18:27
timvandermeij added a commit to timvandermeij/pdf.js that referenced this pull request Jul 28, 2024
This should avoid the timeouts and OOM issues we have on the Linux bot,
which started since PR mozilla#18473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants