Fix intermittent failures with freetext and stamp tests #18338
Conversation
calixteman
force-pushed
the
fix_stamp_test
branch
from
36757ba
to
c5dec61
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/219907e4fc657d4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cf8df11f45f4431/output.txt |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
They're potentially due to some concurrent access to the system clipboard. So this patch makes them sequential.
calixteman
force-pushed
the
fix_stamp_test
branch
from
c5dec61
to
0e94f2b
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/219907e4fc657d4/output.txt Total script time: 7.87 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/cf8df11f45f4431/output.txt Total script time: 18.10 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4f1fc9a8dc638b8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/216551cd9e0ed2c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4f1fc9a8dc638b8/output.txt Total script time: 7.85 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/216551cd9e0ed2c/output.txt Total script time: 18.24 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b047e7c58cf0bd8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/134a44a70b5e072/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b047e7c58cf0bd8/output.txt Total script time: 7.87 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/134a44a70b5e072/output.txt Total script time: 16.69 mins
|
There was a problem hiding this comment.
Nice, I was just about to make this exact patch today after coming to the same conclusion about concurrent system clipboard access yesterday. This was a really tough one to figure out, but eventually it worked out by copying text from another window and then seeing that text from the system clipboard being pasted in the browser. The chance of that happening is also pretty high given that the Chrome and Firefox tests run pretty much at the same time, and it also explains why sometimes seemingly "random" results were seen in the assertions.
In short, thank you for doing this, and with this we should finally have gotten rid of all those pesky copy/paste intermittents and waitForEvent logs!
They're potentially due to some concurrent access to the system clipboard. So this patch makes them sequential.