Use waitForEvent in the pasteFromClipboard integration test helper function
#18326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8a3d2f22102b7c6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/02d98f9c7934571/output.txt |
timvandermeij
changed the title
waitForEvent in the pasteFromClipboard integration test helper function
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/02d98f9c7934571/output.txt Total script time: 8.12 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8a3d2f22102b7c6/output.txt Total script time: 19.03 mins
|
…r function This code contains the same bug that the previous commit fixed in `waitForEvent`, namely that we don't clear the timeout if the event is triggered. By using the now fixed `waitForEvent` function we not only deduplicate this code but we also fix this issue so that no incorrect timeout logs show up anymore.
timvandermeij
force-pushed
the
integration-test-pastefromclipboard
branch
from
789cc65
to
f974b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code contains the same bug that the previous commit fixed in
waitForEvent, namely that we don't clear the timeout if the event is triggered. By using the now fixedwaitForEventfunction we not only deduplicate this code but we also fix this issue so that no incorrect timeout logs show up anymore.Note that this patch gets rid of the incorrect timeout logs, but this doesn't solve the problem of the correct timeout logs yet (but it's preparatory work for follow-up patches that address that problem).
Fixes a part of #17931.