Try to shutdown Fluent "more" when closing the viewer during testing #18313
Conversation
Snuffleupagus
force-pushed
the
l10n-destroy
branch
from
31e0f22
to
9b59c39
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/54f75296e941b9a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b82c125d393cae9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/54f75296e941b9a/output.txt Total script time: 8.29 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b82c125d393cae9/output.txt Total script time: 19.89 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/20035c2f2dc0765/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b0c863dbc59554a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/20035c2f2dc0765/output.txt Total script time: 8.45 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b0c863dbc59554a/output.txt Total script time: 17.51 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/97a01dde8fd4e58/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/232f860fe14b23d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/97a01dde8fd4e58/output.txt Total script time: 8.17 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/232f860fe14b23d/output.txt Total script time: 16.83 mins
|
Even with PR 18280 fixed, we still *occasionally* see l10n-related errors when closing the integration-tests on the bots.
Snuffleupagus
force-pushed
the
l10n-destroy
branch
from
9b59c39
to
6492587
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5ae7c79b8bea53b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ae7a2979558207a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ae7a2979558207a/output.txt Total script time: 8.16 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5ae7c79b8bea53b/output.txt Total script time: 16.67 mins
|
|
Thank you for improving this! |
Given that `pendingElements` was already being cleared, just below, there won't be anything to translate and as far as I can tell keeping the `requestAnimationFrame` running shouldn't be necessary. Note that this was found in the PDF.js project, please refer to [this discussion](mozilla/pdf.js#18313 (comment)), where we're trying to shutdown various asynchronous operations when running tests and currently Fluent make this difficult.
Given that `pendingElements` was already being cleared, just below, there won't be anything to translate and as far as I can tell keeping the `requestAnimationFrame` running shouldn't be necessary. Note that this was found in the PDF.js project, please refer to [this discussion](mozilla/pdf.js#18313 (comment)), where we're trying to shutdown various asynchronous operations when running tests and currently Fluent make this difficult.
Even with PR #18280 fixed, we still occasionally see l10n-related errors when closing the integration-tests on the bots.