Expose entireWord in updateFindControlState #18303
Conversation
There was a problem hiding this comment.
Please squash the commits, and please also ensure that the commit message contains all of the context from #18303 (comment).
bootleq
force-pushed
the
findbar-state-entire-word
branch
from
fbdc420
to
5a9bcda
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/13a29b0a0c35890/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/959293c25a66bbf/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/959293c25a66bbf/output.txt Total script time: 28.72 mins
Image differences available at: http://54.241.84.105:8877/959293c25a66bbf/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/13a29b0a0c35890/output.txt Total script time: 44.18 mins
Image differences available at: http://54.193.163.58:8877/13a29b0a0c35890/reftest-analyzer.html#web=eq.log |
|
Please squash the commits, since we don't use separate fixup commits in this project. |
Allow apps with supportsIntegratedFind to better monitor the find state. A recognized use case is the Firefox findbar, its "not found" sound must consider `entireWord` and only make noise when it is off. See related implementation in https://hg.mozilla.org/mozilla-central/rev/16b902cbcf26 This change can help if we have to move the implementation from cpp to jsm.
bootleq
force-pushed
the
findbar-state-entire-word
branch
from
f7e9ec5
to
890c567
Compare
|
Looks good to me too, especially with the added test. Thank you! |
This is a request to additionally expose
entireWordstate inupdateFindControlState.Have a use case
I am studying Firefox findbar behavior when viewing PDF, especially the "not found" sound.
The condition of the sound requires to consider whether
entireWordis checked.See related implementation in https://hg.mozilla.org/mozilla-central/rev/16b902cbcf26
This PR would help if I move the implementation from cpp to jsm.