Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new helper, in the viewer, to close everything during testing #18289

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This has two advantages, as far as I'm concerned:

  • The tests don't need to manually invoke multiple functions to properly clean-up, which reduces the risk of missing something.
  • By collecting all the relevant clean-up in one method, rather than spreading it out, we get a much better overview of exactly what is being reset.

@Snuffleupagus
Copy link
Collaborator Author

@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
web/app.js Show resolved Hide resolved
This has two advantages, as far as I'm concerned:
 - The tests don't need to manually invoke multiple functions to properly clean-up, which reduces the risk of missing something.
 - By collecting all the relevant clean-up in one method, rather than spreading it out, we get a much better overview of exactly what is being reset.
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Jun 19, 2024
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4f909edbd4b36de/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d5b189e3649fdcc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/4f909edbd4b36de/output.txt

Total script time: 7.71 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d5b189e3649fdcc/output.txt

Total script time: 18.76 mins

  • Integration Tests: FAILED

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks! We only need to make sure that we have a follow-up for mozilla-central: once this lands there the existing unbindWindowEvents calls will likely behave differently because we don't call the global abort controller anymore, which is now moved out into the new testingClose API.

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 94cbe9e into mozilla:master Jun 19, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the app-testingClose branch June 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants