-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new helper, in the viewer, to close everything during testing #18289
Conversation
When this reaches mozilla-central, we should be able to replace https://searchfox.org/mozilla-central/rev/b11735b86bb4d416c918e2b2413456561beff50c/toolkit/components/pdfjs/test/head.js#49-50 respectively https://searchfox.org/mozilla-central/rev/b11735b86bb4d416c918e2b2413456561beff50c/dom/security/test/csp/browser_pdfjs_not_subject_to_csp.js#55-56 with |
fbef076
to
4955810
Compare
4955810
to
eeb5fa8
Compare
This has two advantages, as far as I'm concerned: - The tests don't need to manually invoke multiple functions to properly clean-up, which reduces the risk of missing something. - By collecting all the relevant clean-up in one method, rather than spreading it out, we get a much better overview of exactly what is being reset.
eeb5fa8
to
c771ac8
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4f909edbd4b36de/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d5b189e3649fdcc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4f909edbd4b36de/output.txt Total script time: 7.71 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d5b189e3649fdcc/output.txt Total script time: 18.76 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; thanks! We only need to make sure that we have a follow-up for mozilla-central: once this lands there the existing unbindWindowEvents
calls will likely behave differently because we don't call the global abort controller anymore, which is now moved out into the new testingClose
API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
This has two advantages, as far as I'm concerned: