Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use the l10n fallback bundle when normal ftl-file fetching failed (issue 18264) #18270

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus Snuffleupagus added viewer l10n Localization labels Jun 18, 2024
@Snuffleupagus Snuffleupagus linked an issue Jun 18, 2024 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/85cb0d9a8139357/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dd6931ebd0a2e0f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/dd6931ebd0a2e0f/output.txt

Total script time: 28.56 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/dd6931ebd0a2e0f/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/85cb0d9a8139357/output.txt

Total script time: 41.64 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/85cb0d9a8139357/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/68fd3585d81c608/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/68fd3585d81c608/output.txt

Total script time: 1.00 mins

Published

@timvandermeij timvandermeij merged commit c07dd17 into mozilla:master Jun 18, 2024
7 checks passed
@timvandermeij
Copy link
Contributor

I have confirmed locally that this indeed fixes the logs if dumpio: true is enabled. Great; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n Localization viewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dumpio: true logs about #createBundleFallback
3 participants