Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a wait cursor when saving #18243

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

calixteman
Copy link
Contributor

When the document is a bit long to save (for example in modifying a large document)
we must have something indicating that pdf.js is doing something.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed; thank you!

web/app.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
web/pdf_viewer.css Outdated Show resolved Hide resolved
When the document is a bit long to save (for example in modifying a large document)
we must have something indicating that pdf.js is doing something.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e8eda399d801902/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/209eb062616357e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/e8eda399d801902/output.txt

Total script time: 7.76 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/209eb062616357e/output.txt

Total script time: 52.45 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit e3caa3c into mozilla:master Jun 14, 2024
7 checks passed
@calixteman calixteman deleted the disable_ui_when_saving branch June 14, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants