Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the integration test in adding a function to turn on/off an editing tool #18165

Merged
merged 1 commit into from
May 27, 2024
Merged

Simplify the integration test in adding a function to turn on/off an editing tool #18165

merged 1 commit into from
May 27, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/78f5819be563d0f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2acd7b2fe626ab5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2acd7b2fe626ab5/output.txt

Total script time: 3.46 mins

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/78f5819be563d0f/output.txt

Total script time: 7.77 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor Author

I don't manage to connect the windows bot. Maybe there are some network issues.

@calixteman
Copy link
Contributor Author

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2de71eb90a4521c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2de71eb90a4521c/output.txt

Total script time: 20.99 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes May 27, 2024
View reviewed changes
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b485d8a53135c91/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/705e7f579b44dfa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/b485d8a53135c91/output.txt

Total script time: 7.68 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/705e7f579b44dfa/output.txt

Total script time: 21.24 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 4bdc75f into mozilla:master May 27, 2024
7 checks passed
@timvandermeij timvandermeij removed their request for review May 28, 2024 11:14
@timvandermeij
Copy link
Contributor

Thank you for doing this refactoring; looks much better/simpler like this!

@calixteman calixteman mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @timvandermeij @Snuffleupagus