[api-minor] Improve the FileSpec implementation
#18034
Conversation
- Check that the `filename` is actually a string, before parsing it further. - Use proper "shadowing" in the `filename` getter. - Add a bit more validation of the data in `pickPlatformItem`. - Last, but not least, return both the original `filename` and the (path stripped) variant needed in the display-layer and viewer.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fd2eec2ae3c1eb8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3eb432e881ecdc9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/fd2eec2ae3c1eb8/output.txt Total script time: 27.55 mins
Image differences available at: http://54.241.84.105:8877/fd2eec2ae3c1eb8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3eb432e881ecdc9/output.txt Total script time: 42.70 mins
Image differences available at: http://54.193.163.58:8877/3eb432e881ecdc9/reftest-analyzer.html#web=eq.log |
…enameFromUrl` helper function
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/19f3b79306c3a24/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0518ed54350afbe/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/19f3b79306c3a24/output.txt Total script time: 12.55 mins
Image differences available at: http://54.241.84.105:8877/19f3b79306c3a24/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0518ed54350afbe/output.txt Total script time: 24.02 mins
Image differences available at: http://54.193.163.58:8877/0518ed54350afbe/reftest-analyzer.html#web=eq.log |
filenameis actually a string, before parsing it further.filenamegetter.pickPlatformItem.filenameand the (path stripped) variant needed in the display-layer and viewer.