Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Expose the /Desc-attribute of file attachments in the viewer (issue 18030) #18031

Merged
merged 1 commit into from
May 1, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

In the viewer this will be displayed in the title of the hyperlink, which is probably the best we can do here given how the viewer is implemented.

…wer (issue 18030)

In the viewer this will be displayed in the `title` of the hyperlink, which is probably the best we can do here given how the viewer is implemented.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bd1370606c2a067/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d021206eab8145f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/d021206eab8145f/output.txt

Total script time: 26.63 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 19
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/d021206eab8145f/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/bd1370606c2a067/output.txt

Total script time: 40.92 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/bd1370606c2a067/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/235e34223eca4b0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/235e34223eca4b0/output.txt

Total script time: 1.30 mins

Published

@calixteman
Copy link
Contributor

The tooltip isn't displayed on nightly because of:
https://bugzilla.mozilla.org/show_bug.cgi?id=1894135
But for the rest, it looks good to me.

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 16dbf5d into mozilla:master May 1, 2024
8 of 9 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-18030 branch May 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display /Desc from /Filespec dictionary
3 participants