Workaround for the rust-installer having \cr\lf newlines. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See mozilla#183. Calls dos2unix on the installer script before installing it.
|
This seems to have been fixed upstream, do you still want these changes to be landed? |
|
I think we might close the pull request then. The only issue is about one month of nightly compilers that won’t work without this patch, but for me personally that’s not that important. |
|
If anybody needs to test with this one month of nightly, feel free reply here or cherry-pick these changes locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #183. Calls dos2unix on the installer script before installing it.