Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable some workflows for dependabot PRs #2435

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

larseggert
Copy link
Collaborator

Because they run a long time and aren't really necessary for PRs that only update dependencies.

Because they run a long time and aren't really necessary for PRs that
only update dependencies.
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (b6e4cfc) to head (f86defb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         114      114           
  Lines       37111    37111           
  Branches    37111    37111           
=======================================
+ Hits        35362    35363    +1     
+ Misses       1743     1742    -1     
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to b6e4cfc.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert larseggert enabled auto-merge February 10, 2025 14:29
Copy link

Benchmark results

Performance differences relative to b6e4cfc.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [10.856 µs 10.887 µs 10.925 µs]
       change: [-0.4351% +0.0856% +0.6246%] (p = 0.76 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
3 (3.00%) low severe
1 (1.00%) low mild
1 (1.00%) high mild
8 (8.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.1270 ms 3.1361 ms 3.1468 ms]
       change: [-0.3954% +0.0438% +0.4929%] (p = 0.85 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
8 (8.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [17.626 µs 17.672 µs 17.724 µs]
       change: [-1.0810% -0.3880% +0.2236%] (p = 0.26 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
2 (2.00%) low severe
2 (2.00%) low mild
12 (12.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.4050 ms 5.4179 ms 5.4319 ms]
       change: [-0.3608% -0.0228% +0.3203%] (p = 0.91 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
16 (16.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.6565 µs 6.6766 µs 6.6983 µs]
       change: [-0.6905% -0.0476% +0.6119%] (p = 0.89 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) low mild
2 (2.00%) high mild

decode 1048576 bytes, mask 3f: 💔 Performance has regressed.
       time:   [1.7765 ms 1.7874 ms 1.7985 ms]
       change: [+1.0114% +1.6363% +2.3420%] (p = 0.00 < 0.05)

Found 22 outliers among 100 measurements (22.00%)
1 (1.00%) high mild
21 (21.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [90.996 ns 91.286 ns 91.587 ns]
       change: [-0.6805% -0.1207% +0.4061%] (p = 0.67 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
7 (7.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [109.14 ns 109.39 ns 109.70 ns]
       change: [-0.1474% +0.1198% +0.3981%] (p = 0.41 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [108.83 ns 109.16 ns 109.59 ns]
       change: [-1.2713% -0.4759% +0.1699%] (p = 0.23 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
3 (3.00%) low severe
3 (3.00%) low mild
5 (5.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [93.409 ns 93.581 ns 93.766 ns]
       change: [-0.9455% -0.0261% +0.8374%] (p = 0.96 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.50 ms 111.55 ms 111.61 ms]
       change: [+0.1229% +0.1885% +0.2537%] (p = 0.00 < 0.05)

Found 10 outliers among 100 measurements (10.00%)
8 (8.00%) low mild
2 (2.00%) high mild

SentPackets::take_ranges: No change in performance detected.
       time:   [5.2545 µs 5.4065 µs 5.5635 µs]
       change: [-17.079% -4.9550% +3.8849%] (p = 0.59 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
5 (5.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [36.580 ms 36.650 ms 36.721 ms]
       change: [-1.5435% -1.2784% -1.0240%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [36.934 ms 36.997 ms 37.062 ms]
       change: [-0.5141% -0.2655% -0.0150%] (p = 0.05 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [36.817 ms 36.886 ms 36.956 ms]
       change: [-0.5178% -0.2620% -0.0056%] (p = 0.04 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [37.081 ms 37.147 ms 37.212 ms]
       change: [-0.1023% +0.1440% +0.3774%] (p = 0.24 > 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [859.32 ms 868.18 ms 877.36 ms]
       thrpt:  [113.98 MiB/s 115.18 MiB/s 116.37 MiB/s]
change:
       time:   [-1.9100% -0.4928% +1.0597%] (p = 0.53 > 0.05)
       thrpt:  [-1.0486% +0.4952% +1.9472%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [316.07 ms 319.87 ms 323.65 ms]
       thrpt:  [30.897 Kelem/s 31.262 Kelem/s 31.638 Kelem/s]
change:
       time:   [-1.9294% -0.2162% +1.4390%] (p = 0.80 > 0.05)
       thrpt:  [-1.4186% +0.2167% +1.9673%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [25.414 ms 25.581 ms 25.756 ms]
       thrpt:  [38.827  elem/s 39.092  elem/s 39.348  elem/s]
change:
       time:   [-0.9677% -0.0505% +0.8794%] (p = 0.91 > 0.05)
       thrpt:  [-0.8718% +0.0505% +0.9772%]

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold.
       time:   [1.8248 s 1.8417 s 1.8586 s]
       thrpt:  [53.804 MiB/s 54.298 MiB/s 54.802 MiB/s]
change:
       time:   [-2.9670% -1.7129% -0.3786%] (p = 0.01 < 0.05)
       thrpt:  [+0.3801% +1.7427% +3.0577%]

Client/server transfer results

Performance differences relative to b6e4cfc.

Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.

Client Server CC Pacing Mean ± σ Min Max Δ main Δ main
neqo neqo reno on 543.7 ± 54.9 469.9 785.2 -0.9 -0.0%
neqo neqo reno 533.4 ± 45.5 471.2 666.1 -22.3 -1.0%
neqo neqo cubic on 547.3 ± 27.3 495.1 613.2 4.0 0.2%
neqo neqo cubic 539.2 ± 28.6 478.7 598.3 4.7 0.2%
google neqo reno on 904.8 ± 93.4 657.4 996.5 2.7 0.1%
google neqo reno 903.7 ± 103.0 663.0 1070.6 1.6 0.0%
google neqo cubic on 897.2 ± 100.1 637.8 990.4 2.1 0.1%
google neqo cubic 893.7 ± 97.0 653.2 994.8 -0.8 -0.0%
google google 538.6 ± 17.8 517.4 595.6 3.6 0.2%
neqo msquic reno on 220.3 ± 11.4 204.7 244.4 -5.8 -0.7%
neqo msquic reno 226.7 ± 31.4 199.2 344.2 5.4 0.6%
neqo msquic cubic on 226.0 ± 35.1 201.6 399.3 0.3 0.0%
neqo msquic cubic 221.5 ± 12.6 199.4 247.5 2.0 0.2%
msquic msquic 110.7 ± 9.6 91.3 132.4 -8.0 -1.8%

⬇️ Download logs

@larseggert larseggert disabled auto-merge February 11, 2025 08:50
@larseggert larseggert merged commit 1d9de16 into mozilla:main Feb 11, 2025
72 of 75 checks passed
@larseggert larseggert deleted the ci-dependabot-less branch February 11, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant