Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qlog reference_time should be in msec #2053

Merged
merged 3 commits into from
Aug 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion neqo-common/src/qlog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ pub fn new_trace(role: Role) -> qlog::TraceSeq {
// We can't do the obvious two-step conversion with f64::from(i32::try_from(...)),
// because that overflows earlier than is ideal. This should be fine for a while.
#[allow(clippy::cast_precision_loss)]
Some(time::OffsetDateTime::now_utc().unix_timestamp() as f64)
Some((time::OffsetDateTime::now_utc().unix_timestamp() * 1000) as f64)
larseggert marked this conversation as resolved.
Show resolved Hide resolved
},
time_format: Some("relative".to_string()),
}),
Expand Down
Loading