feat: Obtain info via routing sockets #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 92.94% 93.61% +0.67%
==========================================
Files 1 5 +4
Lines 241 517 +276
==========================================
+ Hits 224 484 +260
- Misses 17 33 +16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Closed
|
@martinthomson @mxinden I think this is ready for you to take a look at. @mozkeeler's review improved things a lot. |
martinthomson
requested changes
Nov 11, 2024
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
larseggert
force-pushed
the
feat-from-routing
branch
from
734d841 to
a3b2240
Compare
|
I rolled this back to before I started to add Solaris support, which is now in #45. @martinthomson I think you still had some things you needed to review? |
martinthomson
approved these changes
Nov 21, 2024
mxinden
added a commit
to mxinden/mtu
that referenced
this pull request
Nov 29, 2024
mozilla#29 added the following `libc` import: ``` rust use libc::{ freeifaddrs, getifaddrs, getpid, if_data, if_indextoname, ifaddrs, in6_addr, in_addr, sockaddr_in, sockaddr_in6, sockaddr_storage, AF_UNSPEC, PF_ROUTE, RTAX_MAX, }; ``` `RTAX_MAX` was added in `libc` `0.2.160`: https://github.com/rust-lang/libc/releases/tag/0.2.160 More specifically rust-lang/libc#3714. This commit makes sure the above new requirement is encoded in the `mtu` `Cargo.toml` `libc` dependency declaration. See CI failure without discussed in mozilla#51 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to mess around with Internet sockets, which Firefox does not allow Rust code to do currently.
Also rolls in quite a few more changes.