Parse and expose tenc members related to cbcs + tests #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure above appears to be a failure in the CI env rather than a code issue. |
Looks like rust-lang/rust#55571, which should be fixed overnight. |
kinetiknz
approved these changes
Nov 2, 2018
Parse the tenc members for: - crypt_byte_block: number of encrypted bytes in the pattern if pattern encryption is used - skip_byte_block: number of clear bytes in the pattern if pattern encryption is used - constant_iv: the iv that is used for a track by certain pattern based encryption schemes, such as cbcs Update the data structures used to contain new data. Note, the is_encrypted member of the tenc structure has been changed from a u32 to a u8 to reflect changes in the spec. This changes our interface.
The new members being parsed on the tenc box should not exist in the current test files. Update the existing tests to reflect this.
Add tests to both mp4parse and mprparse_capi to verify parsing of encrypted mp4s. These primarily focus on cbcs encryption, but some new cenc tests have also been added to the c-api to provide further coverage.
SingingTree
force-pushed
the
tenc_cbcs
branch
from
06216a7 to
09986d6
Compare
|
Updated. I have sent the spec via other channels given its proprietary nature. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.