reintroduce topic cards with performance fix #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
force-pushed
the
reintroduce-topic-cards-with-fix
branch
3 times, most recently
from
b4cf25e to
b20a2d7
Compare
escattone
force-pushed
the
reintroduce-topic-cards-with-fix
branch
from
b20a2d7 to
f73b1d3
Compare
smithellis
approved these changes
Feb 10, 2025
escattone
commented
Feb 10, 2025
|
|
||
| visits = visits[:10] |
There was a problem hiding this comment.
This was the change that killed the performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#2180
Notes
get_featured_articles.get_featured_articlesso that's it's clearer, simpler, and much faster, and added thorough tests.prefetch_relatedfor each document's products and topics, because they're not used by any code that uses the featured articles. I think at one point in the iterations of the topic-cards work they were used, but that's no longer the case.select_related("current_revision")because that eliminates an N+1 query for each featured article's current revision to get the current revision's summary (this is done in the templates).