Playwright expand coverage to include the latest changes made against the Knowledge Base Dashboard #6450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emilghittasv
commented
Jan 14, 2025
emilghittasv
commented
- Expand the _submit_new_kb_revision() so it can also mark the revision as "needs change", "ready for localization" and significance type. Also created a new defer_revision() function which should handle deferring the article revisions.
- Expanding playwright coverage to test different l10n status updates inside the Knowledge Base Dashboard (minor and deferred revisions should not have an impact in the l10n Status)
…on as "needs change", "ready for localization" and significance type. Also created a new defer_revision() function which should handle deferring the article revisions. - Expanding playwright coverage to test different l10n status updates inside the Knowledge Base Dashboard (minor and deferred revisions should not have an impact in the l10n Status)
escattone
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.