Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright - Fix delete cookies check & update test_synonyms file #6444

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

emilghittasv
Copy link
Collaborator

  • There are some cases in which deleting the playwright user session redirects to the login page (depending on which page the session cookies deletion was performed). Since the login page doesn't contain the top navbar options, we must treat the login page as a pass while checking that the user was indeed signed out after the session deletion. This fix should improve the execution time on those particular tests by breaking out from the attempts/retry loop.
  • It seems that searching for "popups" will also return results containing "pops up". I'm adding that to the synonm list.

@emilghittasv emilghittasv merged commit 93693d3 into mozilla:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants