Optimize topics hierarchy helper #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
changed the title
akatsoulas
force-pushed
the
optimize-topic-hierarchy
branch
from
33782f1 to
98f41bc
Compare
escattone
reviewed
Dec 10, 2024
There was a problem hiding this comment.
When no product is provided in the URL, this still has the problem of making N queries -- where N is the total number of questions in the moderation queue.
By caching based on the question.product.slug, we can provide caching for both cases, when a product slug is provided in the URL, and when one isn't.
I'll add a commit that does that.
smithellis
pushed a commit
to smithellis/kitsune
that referenced
this pull request
Dec 19, 2024
* Optimize topics hieararchy helper * adjust get_hierarchical_topics() for product caching --------- Co-authored-by: Ryan Johnson <rjohnson@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.